Introduce versioning to the DurableTaskClient #393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halspang
force-pushed
the
halspang/client_versioning
branch
from
0f8256d to
0cfd1d2
Compare
cgillum
reviewed
Mar 11, 2025
cgillum
reviewed
Mar 11, 2025
src/Client/Core/DependencyInjection/DurableTaskClientBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
test/Client/Grpc.Tests/DependencyInjection/DurableTaskClientBuilderExtensionsTests.cs
Outdated
Show resolved
Hide resolved
This change adds a DefaultVersion to the DurableTaskClient builder options. When no other version is set, which is currently always the case, this value is used as the version of any new orchestration started. The value is then passed down to workers via the TaskOrchestrationContext. This allows users to specify a version during their app setup and then key off of the version during orchestration. Using conditional logic, changes can then be made to the orchestration without harming in-progress orchestrations. Signed-off-by: halspang <[email protected]>
halspang
force-pushed
the
halspang/client_versioning
branch
from
0cfd1d2 to
f4d80f2
Compare
cgillum
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a DefaultVersion to the DurableTaskClient builder options. When no other version is set, which is currently always the case, this value is used as the version of any new orchestration started. The value is then passed down to workers via the TaskOrchestrationContext.
This allows users to specify a version during their app setup and then key off of the version during orchestration. Using conditional logic, changes can then be made to the orchestration without harming in-progress orchestrations.